Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix jruby encoding in new thread (#12919)
In jruby `runtime.evalScriptlet('Encoding::UTF_8')` can be broken under a newly created thread, which can cause protobuf encoding to fail. For example: https://github.com/ntkme/sass-embedded-host-ruby/actions/runs/5108602231/jobs/9182569583#step:5:544 It real issue seems to be in jruby itself. A bug report with minimal reproduction has been filed at jruby/jruby#7820 This PR fixes the problem by effectively replacing `runtime.evalScriptlet('Encoding::UTF_8')` with `runtime.getEncodingService().convertEncodingToRubyEncoding(org.jcodings.specific.UTF8Encoding.INSTANCE)`, which works on all threads. Closes #12919 COPYBARA_INTEGRATE_REVIEW=#12919 from ntkme:fix-jruby-encoding 345680e FUTURE_COPYBARA_INTEGRATE_REVIEW=#12919 from ntkme:fix-jruby-encoding 345680e PiperOrigin-RevId: 536490901
- Loading branch information