Extend MapField swap test to include the unsafe swap version.

It uses a different codepath in the MapField implementation. PiperOrigin-RevId: 708078880
protocolbuffers · Dec 20, 2024 · 47f5b75 · 47f5b75
1 parent efbd632
commit 47f5b75
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/google/protobuf/map_test.inc b/src/google/protobuf/map_test.inc
@@ -1379,6 +1379,13 @@ TEST_P(MapTestWithParams, SwapMapsFieldsViaReflection) {
 
   reflection_tester.ExpectClearViaReflectionIterator(lhs);
   reflection_tester.ExpectMapFieldsSetViaReflectionIterator(rhs);
+
+  if (lhs_arena == rhs_arena) {
+    // If they are the same arena, we can try the unsafe swap.
+    lhs->GetReflection()->UnsafeArenaSwapFields(lhs, rhs, fields);
+    reflection_tester.ExpectClearViaReflectionIterator(rhs);
+    reflection_tester.ExpectMapFieldsSetViaReflectionIterator(lhs);
+  }
 }
 
 class MapTestCodegenOrDynamic : public testing::TestWithParam<bool> {};