Update comment for why templated function for Grow<> does not work here

PiperOrigin-RevId: 546289557
protocolbuffers · Jul 7, 2023 · 5db61db · 5db61db
1 parent cca0eee
commit 5db61db
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/google/protobuf/repeated_field.h b/src/google/protobuf/repeated_field.h
@@ -1064,9 +1064,11 @@ PROTOBUF_NOINLINE void RepeatedField<Element>::GrowNoAnnotate(int current_size,
   arena_or_elements_ = new_rep->elements();
 }
 
-// TODO(b/266411038): we should really be able to make this:
-// template <bool annotate_size = true>
-// void Grow();
+// Ideally we would be able to use:
+//   template <bool annotate_size = true>
+//   void Grow();
+// However, as explained in b/266411038#comment9, this causes issues
+// in shared libraries for Youtube (and possibly elsewhere).
 template <typename Element>
 PROTOBUF_NOINLINE void RepeatedField<Element>::Grow(int current_size,
                                                     int new_size) {