Skip to content

Commit

Permalink
protoc java: add missing annotation to clearField() for messages
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 525547339
  • Loading branch information
protobuf-github-bot authored and copybara-github committed Apr 19, 2023
1 parent eb8d57a commit 866dfe6
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions src/google/protobuf/compiler/java/message_field.cc
Original file line number Diff line number Diff line change
Expand Up @@ -328,17 +328,19 @@ void ImmutableMessageFieldGenerator::GenerateBuilderMembers(

// Message.Builder clearField()
WriteFieldDocComment(printer, descriptor_);
printer->Print(variables_,
"$deprecation$public Builder clear$capitalized_name$() {\n"
" $clear_has_field_bit_builder$\n"
" $name$_ = null;\n"
" if ($name$Builder_ != null) {\n"
" $name$Builder_.dispose();\n"
" $name$Builder_ = null;\n"
" }\n"
" $on_changed$\n"
" return this;\n"
"}\n");
printer->Print(
variables_,
"$deprecation$public Builder ${$clear$capitalized_name$$}$() {\n"
" $clear_has_field_bit_builder$\n"
" $name$_ = null;\n"
" if ($name$Builder_ != null) {\n"
" $name$Builder_.dispose();\n"
" $name$Builder_ = null;\n"
" }\n"
" $on_changed$\n"
" return this;\n"
"}\n");
printer->Annotate("{", "}", descriptor_);

// Field.Builder getFieldBuilder()
WriteFieldDocComment(printer, descriptor_);
Expand Down

0 comments on commit 866dfe6

Please sign in to comment.