Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add c# serializationDeterministic #12881

Closed
fmg-lydonchandra opened this issue May 23, 2023 · 3 comments
Closed

Add c# serializationDeterministic #12881

fmg-lydonchandra opened this issue May 23, 2023 · 3 comments
Assignees
@jskeet
Labels
c# discussion inactive Denotes the issue/PR has not seen activity in the last 90 days.

Comments

@fmg-lydonchandra
Copy link
Contributor

fmg-lydonchandra commented May 23, 2023 •
edited
Loading

What language does this apply to?
C#

Describe the problem you are trying to solve.
DeterministicSerialization for c#

Describe the solution you'd like
Same API CodedOutputStream.SetSerializationDeterministic for C# binding (same as Java/Ruby/Python API)

Describe alternatives you've considered
PInvoke into C++ library

Additional context
None

Is there any technical reason this has not been implemented for c# ?
@fmg-lydonchandra fmg-lydonchandra added the untriaged auto added to all issues by default when created. label May 23, 2023
@hlopko hlopko added discussion c# and removed untriaged auto added to all issues by default when created. labels May 24, 2023
@jskeet
Copy link
Contributor

jskeet commented May 24, 2023

I'd never heard of it before, but I don't see any reason why it can't be implemented for C#.

Looking at the Java implementation, it looks like this is just about the order in which map entries are serialized - is that your understanding as well?

I doubt that I'll have the time to work on it as a feature any time soon, but I'd happily review a pull request.

@fmg-lydonchandra fmg-lydonchandra mentioned this issue Jun 28, 2023
Closed
@copybara-service copybara-service bot mentioned this issue Sep 22, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Sep 22, 2023
@fmg-lydonchandra @copybara-github
add C# deterministic serialization (#13160)
e827014 
#12881

@jskeet  review please :-) as this is my first contrib to protobuf, any design / performance feedback is very sought after

Closes #13160

COPYBARA_INTEGRATE_REVIEW=#13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b
PiperOrigin-RevId: 567635727
copybara-service bot pushed a commit that referenced this issue Sep 26, 2023
@fmg-lydonchandra @copybara-github
add C# deterministic serialization (#13160)
a969107 
#12881

@jskeet  review please :-) as this is my first contrib to protobuf, any design / performance feedback is very sought after

Closes #13160

COPYBARA_INTEGRATE_REVIEW=#13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b
FUTURE_COPYBARA_INTEGRATE_REVIEW=#13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b
PiperOrigin-RevId: 567635727
copybara-service bot pushed a commit that referenced this issue Sep 26, 2023
@fmg-lydonchandra @copybara-github
add C# deterministic serialization (#13160)
96100bf 
#12881

@jskeet  review please :-) as this is my first contrib to protobuf, any design / performance feedback is very sought after

Closes #13160

COPYBARA_INTEGRATE_REVIEW=#13160 from fmg-lydonchandra:feature/12881_cs_serialization_deterministic ab7e01b
PiperOrigin-RevId: 568448399
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 12, 2023
@jskeet
Copy link
Contributor

jskeet commented Nov 13, 2023

Fixed in #13160

@jskeet jskeet closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
c# discussion inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jskeet @hlopko @fmg-lydonchandra