Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oneof hazzer gencode incompatibility #14245

Closed
zhangskz opened this issue Sep 28, 2023 · 0 comments
Closed

Oneof hazzer gencode incompatibility #14245

zhangskz opened this issue Sep 28, 2023 · 0 comments
Assignees
@zhangskz
Labels
24.x 26.x java

Comments

@zhangskz
Copy link
Member

Version: 3.24.x
Language: Java

2a55706 is a breaking change for oneofs for gencode before 3.15.x.

This technically violates https://protobuf.dev/support/cross-version-runtime-guarantee/ since we currently guarantee compatibility with old gencode and new runtimes within same major version.

This should be rolled back and reintroduced in the next release that bumps the Java major version.
@zhangskz zhangskz added the untriaged auto added to all issues by default when created. label Sep 28, 2023
@zhangskz zhangskz self-assigned this Sep 28, 2023
@zhangskz zhangskz added java 24.x 26.x and removed untriaged auto added to all issues by default when created. labels Sep 28, 2023
zhangskz referenced this issue Sep 28, 2023
@zhangskz @copybara-github
Migrate away from examining the syntax of a proto file via reflection.
2a55706 
PiperOrigin-RevId: 511796130
zhangskz referenced this issue Sep 28, 2023
@zhangskz @copybara-github
Automated rollback of commit 2a55706.
30b6251 
PiperOrigin-RevId: 569253919
@zhangskz zhangskz mentioned this issue Sep 28, 2023
Merged
@zhangskz zhangskz mentioned this issue Nov 3, 2023
Closed
@copybara-service copybara-service bot mentioned this issue Nov 29, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Nov 29, 2023
@zhangskz @copybara-github
Breaking change: Add has methods to ReflectionInvoker for groups and …
045f70d 
…oneofs that have presence. This breaks compatibility with gencode before 3.15.x when oneof hazzers were added.

Note our cross version runtime guarantee (#14245) does not guarantee compatibility with old gencode and new runtimes after a major version bump (e.g. 3.15.x -> 4.26.x).

Fixes #14245

PiperOrigin-RevId: 586413359
@zhangskz zhangskz closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangskz zhangskz

Labels
24.x 26.x java
Projects
None yet
Milestone
No milestone
1 participant
@zhangskz