Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added const qualifier to iterator to enable compiling with VS2008 #1

Merged
merged 1 commit into from
Sep 2, 2014
Merged

Added const qualifier to iterator to enable compiling with VS2008 #1

merged 1 commit into from
Sep 2, 2014

Conversation

dhirschfeld
Copy link

No description provided.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Aug 27, 2014

Hi, please sign this Google Individual Contributor License Agreement:
https://developers.google.com/open-source/cla/individual
and update this thread when you are done. This is required for us to use your code.

@dhirschfeld
Copy link
Author

I've submitted the form electronically so we'll see where we go from there...

xfxyjwf added a commit that referenced this pull request Sep 2, 2014
@xfxyjwf
Merge pull request #1 from dhirschfeld/vs2008-fix
6890263 
Added const qualifier to iterator to enable compiling with VS2008
@xfxyjwf xfxyjwf merged commit 6890263 into protocolbuffers:master Sep 2, 2014
@dhirschfeld dhirschfeld deleted the vs2008-fix branch September 18, 2014 08:40
@jspal jspal mentioned this pull request Oct 24, 2014
Closed
@cloudkey cloudkey mentioned this pull request Feb 4, 2015
Closed
anandolee pushed a commit that referenced this pull request Apr 18, 2015
@jtattermusch
Merge pull request #1 from jtattermusch/csharp_protogen_rewrite
8394a8d 
Rewrite of C# protogen to C++ (initial version)
anandolee added a commit that referenced this pull request May 1, 2015
@anandolee
Merge pull request #1 from google/csharp
8bae6c0 
Csharp update
TeBoring pushed a commit that referenced this pull request Jun 2, 2015
@murgatroid99
Merge pull request #1 from jcanizales/podspec_fix
8cbb4cf 
A few corrections to the proposed podspec
stoneStyle added a commit to stoneStyle/protobuf that referenced this pull request Dec 1, 2015
@stoneStyle
Merge pull request protocolbuffers#1 from google/master
fb82cc8 
5.25 merge
haberman added a commit that referenced this pull request Feb 8, 2016
@haberman
Merge pull request #1 from nicolasnoble/bin-gems
6efe3aa 
Few fixes.
@deeGraYve deeGraYve mentioned this pull request Feb 26, 2016
Closed
@haberman haberman mentioned this pull request Feb 29, 2016
Closed
@lostindark lostindark mentioned this pull request Mar 15, 2016
Closed
liujisi pushed a commit that referenced this pull request May 12, 2016
@anandolee
Merge pull request #1 from google/beta-3
e1f588a 
Beta 3
@ghost ghost mentioned this pull request Sep 29, 2016
Closed
@jasonhe88 jasonhe88 mentioned this pull request Nov 12, 2016
Closed
@pwtitle pwtitle mentioned this pull request Dec 21, 2016
Closed
@yingzong yingzong mentioned this pull request Feb 15, 2017
Closed
@gatkinso gatkinso mentioned this pull request Apr 6, 2017
Closed
@woding woding mentioned this pull request Jun 5, 2017
Closed
@roczpwu roczpwu mentioned this pull request Jul 21, 2017
Closed
@FZUPotato FZUPotato mentioned this pull request Aug 21, 2017
Closed
@jakiechris jakiechris mentioned this pull request Nov 20, 2017
Closed
@E-HERO E-HERO mentioned this pull request Dec 3, 2017
Closed
@pjebs pjebs mentioned this pull request Dec 12, 2017
Closed
xfxyjwf pushed a commit that referenced this pull request Feb 22, 2018
@abdul-sami
Merge pull request #1 from abdul-sami/abdul-sami-patch-1
ac021a0 
Added instruction for existing ZLIB configuration
@kathyvs kathyvs mentioned this pull request Apr 5, 2018
Closed
@dingjingmaster dingjingmaster mentioned this pull request Oct 31, 2023
Closed
@bach001 bach001 mentioned this pull request Nov 2, 2023
Closed
@lijithomas88 lijithomas88 mentioned this pull request Nov 29, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 14, 2023
@protobuf-github-bot @copybara-github
Avoid interface calls in hot loop
2f87fa9 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 590821750
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2023
@protobuf-github-bot @copybara-github
Avoid interface calls in hot loop
be2e2a3 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 590821750
copybara-service bot pushed a commit that referenced this pull request Dec 15, 2023
@protobuf-github-bot @copybara-github
Avoid interface calls in hot loop
b10d3f9 
Before, every charAt would emit (on android):
```
    0x00002104    adrp x17, #+0x1000 (addr 0x3000)
    0x00002108    ldr w17, [x17, #20]
    0x0000210c    ldr x0, [x0, #128]
    0x00002110    ldr x0, [x0, #328]
    0x00002114    ldr lr, [x0, #24]
    0x00002118    blr lr <-- Call into String.charAt(int)
```
Now, it emits the inlined implementation of charAt (branch is for possibly compressed strings):
```
    0x000020b4    ldur w16, [x4, #-8]
    0x000020b8    tbnz w16, #0, #+0xc (addr 0x20c4)
    0x000020bc    ldrb w4, [x4, x0]
    0x000020c0    b #+0x8 (addr 0x20c8)
    0x000020c4    ldrh w4, [x4, x0, lsl #1]
```

PiperOrigin-RevId: 591147406
@babuveld babuveld mentioned this pull request Jan 12, 2024
Closed
@M-Labedzki M-Labedzki mentioned this pull request May 23, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Aug 12, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
d7ec53c 
PiperOrigin-RevId: 661433949
@copybara-service copybara-service bot mentioned this pull request Aug 12, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Aug 12, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
57b48b5 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
b0f0b51 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
9da7ec1 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
16f187c 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
ebab347 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
b2212c6 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
cf4b3d9 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
4e530ef 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
d696b00 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
0a4eee3 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
7464a80 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
8708327 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
8780107 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
e9b87ca 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
a6f892c 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
f4a47d5 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
1cd89a9 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
ee6afa8 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 16, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
c6e3cb3 
PiperOrigin-RevId: 661433949
copybara-service bot pushed a commit that referenced this pull request Aug 17, 2024
@protobuf-github-bot @copybara-github
Add v2 FieldEntry #1.
a6977fe 
PiperOrigin-RevId: 663974332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirschfeld @xfxyjwf