Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podspecs #10019

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix podspecs #10019

merged 1 commit into from
May 20, 2022

Conversation

deannagarcia
Copy link
Member

@deannagarcia deannagarcia commented May 20, 2022 •
edited
Loading

Change cocoapod specs to use the version as the tag number. We will be tagging each release with the protoc version number, the c++ version number and the cocoapod version number.

acozzette
acozzette approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@acozzette acozzette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will eventually need for both the C++ and Objective-C versions to be tagged since they might not always be the same version.

@deannagarcia
Copy link
Member Author

I think we will eventually need for both the C++ and Objective-C versions to be tagged since they might not always be the same version.

Good point! Will add that to the description and my TODO list.

@deannagarcia deannagarcia merged commit 6d2827b into protocolbuffers:21.x May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deannagarcia @acozzette @protobuf-kokoro