Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #10581 from jhump/jh/custom-json-name-validation" #10657

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Revert "Merge pull request #10581 from jhump/jh/custom-json-name-validation" #10657

merged 3 commits into from
Sep 26, 2022

Conversation

mkruskal-google
Copy link
Member

@mkruskal-google mkruskal-google commented Sep 26, 2022 •
edited
Loading

This reverts commit d3b5389, reversing changes made to bcd1755.

This PR breaks internal google code, and should be submitted internally instead.

@mkruskal-google
Revert "Merge pull request protocolbuffers#10581 from jhump/jh/custom…
1a68157 
…-json-name-validation"

This reverts commit d3b5389, reversing
changes made to bcd1755.
@mkruskal-google mkruskal-google merged commit d58d471 into protocolbuffers:main Sep 26, 2022
@mkruskal-google
Copy link
Member Author

@jhump FYI

@mkruskal-google mkruskal-google deleted the revert-json-pr branch September 27, 2022 19:40
@jhump jhump mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcy mcy mcy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkruskal-google @mcy @protobuf-kokoro