Remove erroneous dependencies @com_google_googletest//:gtest and @com… #12276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_google_googletest//:gtest_main from //src/google/protobuf/json:parser (protocolbuffers#12267) Downstream bazel projects that depend on protoc would need to provide googletest dependencies when it should not be necessary to do so. Fixes protocolbuffers#11409 Closes protocolbuffers#12267 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#12267 from prestonvanloon:remove-erroneous-googletest-dep 09fd163 PiperOrigin-RevId: 517974450
deannagarcia
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
deannagarcia
approved these changes
Mar 20, 2023
|
I'm hitting Looking forward to this fix to be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_google_googletest//:gtest_main from //src/google/protobuf/json:parser (#12267)
Downstream bazel projects that depend on protoc would need to provide googletest dependencies when it should not be necessary to do so.
Fixes #11409
Closes #12267
COPYBARA_INTEGRATE_REVIEW=#12267 from prestonvanloon:remove-erroneous-googletest-dep 09fd163 PiperOrigin-RevId: 517974450