Delete cmake/CMakeLists.txt in favor of CMakeLists.txt #12295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deannagarcia
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
zhangskz
approved these changes
Mar 21, 2023
jtattermusch
added a commit
to grpc/grpc
that referenced
this pull request
Mar 22, 2023
…#32678) Try to react to protocolbuffers/protobuf#12263 and protocolbuffers/protobuf#12295 Protobuf's /cmake/CMakeLists.txt is now deprecated if favor of /CMakeLists.txt https://github.com/protocolbuffers/protobuf/blob/58ecf38aa521ba812a0c1a0ae9f108dd311c739c/cmake/CMakeLists.txt#L3 In this PR: - Adjust `cmake/protobuf.cmake` to use the right CMakeLists.txt - adjust the C++ distribtests accordingly
jtattermusch
added a commit
to jtattermusch/grpc
that referenced
this pull request
Mar 24, 2023
…grpc#32678) Try to react to protocolbuffers/protobuf#12263 and protocolbuffers/protobuf#12295 Protobuf's /cmake/CMakeLists.txt is now deprecated if favor of /CMakeLists.txt https://github.com/protocolbuffers/protobuf/blob/58ecf38aa521ba812a0c1a0ae9f108dd311c739c/cmake/CMakeLists.txt#L3 In this PR: - Adjust `cmake/protobuf.cmake` to use the right CMakeLists.txt - adjust the C++ distribtests accordingly
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…grpc#32678) Try to react to protocolbuffers/protobuf#12263 and protocolbuffers/protobuf#12295 Protobuf's /cmake/CMakeLists.txt is now deprecated if favor of /CMakeLists.txt https://github.com/protocolbuffers/protobuf/blob/58ecf38aa521ba812a0c1a0ae9f108dd311c739c/cmake/CMakeLists.txt#L3 In this PR: - Adjust `cmake/protobuf.cmake` to use the right CMakeLists.txt - adjust the C++ distribtests accordingly
wanlin31
pushed a commit
to grpc/grpc
that referenced
this pull request
May 18, 2023
…#32678) Try to react to protocolbuffers/protobuf#12263 and protocolbuffers/protobuf#12295 Protobuf's /cmake/CMakeLists.txt is now deprecated if favor of /CMakeLists.txt https://github.com/protocolbuffers/protobuf/blob/58ecf38aa521ba812a0c1a0ae9f108dd311c739c/cmake/CMakeLists.txt#L3 In this PR: - Adjust `cmake/protobuf.cmake` to use the right CMakeLists.txt - adjust the C++ distribtests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #12263, but we will not cherrypick to 22.x since it could be breaking.