Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in #12104 (cherry-pick) #12725

Merged

Commits on May 8, 2023

  1. Fix crash in protocolbuffers#12104

    This crash was due to the fact that we were passing `nullptr` as a `const
    char*` parameter and relying on that implicitly converting into an empty
    `absl::string_view`. `absl::string_view` supports that functionality, but
    starting with C++17 its behavior changes since it's just a type alias for
    `std::string_view`. `std::string_view` does not have any special conversion for
    nullptr and so we were just getting crashes.
    
    PiperOrigin-RevId: 530431663
    acozzette committed May 8, 2023
    Configuration menu
    Copy the full SHA
    afa997d View commit details
    Browse the repository at this point in the history