Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: force relative imports #1511

Closed
wants to merge 1 commit into from

Conversation

little-dude
Copy link

fix #1491

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@little-dude
Copy link
Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@little-dude
Copy link
Author

@haberman as said in #1491 it's not a complete fix. Importing from a subdirectory is still broken, but the fix for this is beyond my reach. It would be nice if you could merge this already, because it covers the most basic needs.

@haberman
Copy link
Member

I have reservations about this change, as I mentioned on the issue #1491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python: use relative imports in generated modules
4 participants