Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move -Werror to our test/dev bazelrc files. #17938

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Move -Werror to our test/dev bazelrc files. #17938

merged 5 commits into from
Aug 23, 2024

Conversation

mkruskal-google
Copy link
Member

Putting it into BUILD files unintentionally forces it on all our downstream users. Instead, we just want to enable this during testing and let them choose for themselves in their builds.

Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.

Closed #14714

PiperOrigin-RevId: 666903224

Putting it into BUILD files unintentionally forces it on all our downstream users.  Instead, we just want to enable this during testing and let them choose for themselves in their builds.

Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.

Closed #14714

PiperOrigin-RevId: 666903224
@mkruskal-google mkruskal-google added the back-port Cherrypick PRs to release branches label Aug 23, 2024
@mkruskal-google mkruskal-google requested review from a team as code owners August 23, 2024 22:08
@mkruskal-google mkruskal-google requested review from deannagarcia and JasonLunn and removed request for a team August 23, 2024 22:08
@mkruskal-google mkruskal-google merged commit f5a1b17 into 28.x Aug 23, 2024
176 checks passed
@mkruskal-google mkruskal-google deleted the werror-28 branch August 23, 2024 23:47
zhangskz added a commit that referenced this pull request Sep 18, 2024
    * Move -Werror to our test/dev bazelrc files.

    Putting it into BUILD files unintentionally forces it on all our downstream users.  Instead, we just want to enable this during testing and let them choose for themselves in their builds.

    Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.

    Closed #14714

    PiperOrigin-RevId: 666903224

    * Fix extra warnings on 28.x

    * Fix zlib issues on macos

    * Second try at zlib/macos issues

    * Only disable deprecated-non-prototype on macos-14
mkruskal-google added a commit that referenced this pull request Sep 18, 2024
* Fix cord handling in DynamicMessage and oneofs.

This fixes a memory corruption vulnerability for anyone using cord with dynamically built descriptor pools.

* Move -Werror to our test/dev bazelrc files. (#17938)

    * Move -Werror to our test/dev bazelrc files.

    Putting it into BUILD files unintentionally forces it on all our downstream users.  Instead, we just want to enable this during testing and let them choose for themselves in their builds.

    Note, that this expands the scope of -Werror to our entire repo for CI, so a bunch of fixes and opt-outs had to be applied to get this change passing.

    Closed #14714

    PiperOrigin-RevId: 666903224

    * Fix extra warnings on 28.x

    * Fix zlib issues on macos

    * Second try at zlib/macos issues

    * Only disable deprecated-non-prototype on macos-14

* Silence expected ubsan failures from absl::Cord

* Fix test dependency

* Fix python/upb warnings

* Fix last upb warning

---------

Co-authored-by: Mike Kruskal <mkruskal@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port Cherrypick PRs to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants