Building python binding with bazel on s390x #19232
Conversation
Signed-off-by: Gong Su <gong_su@hotmail.com>
gongsu832
requested review from
acozzette and
anandolee
and removed request for
a team
esrauchg
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
We don't currently release or have plans to release python binary wheels for s390x. Is this a request for us to add s390x to our release, or is the purpose of this PR to add these config_settings to enable building for s390x yourself (and if so -- why)? |
| @@ -458,6 +479,7 @@ py_dist( | |||
| "win64": "310", | |||
| "linux-x86_64": "38", | |||
| "linux-aarch_64": "38", | |||
| "linux-s390x": "38", | |||
There was a problem hiding this comment.
@gongsu832 Unfortunately I haven't been able to figure out any way to merge this change without breaking our CI, unless I delete this line. Otherwise our build fails because we don't have an appropriate toolchain installed for s390x. Is is still useful to merge the PR without this line? I guess that might still allow you to write your own py_dist() target in a separate repo.
There was a problem hiding this comment.
Hi @acozzette thank you very much for trying to merge this PR. Yes it would still be very helpful for us if you could merge without that line.
Changes needed for building python binding with bazel on s390x.