Move the Sync callback from the vtable to a global variable. #20067
+74
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
There is only one function for the whole binary. We don't need it to exist per instance. It still needs to be injected to prevent a direct dependency from the parser into the reflection runtime. Also, move the check for GetMap/MutableMap to be inlined to avoid a regression in the table-driven parser. Currently it goes through an indirect function call even if the field is clean and needs no sync'n. PiperOrigin-RevId: 716350983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Sync callback from the vtable to a global variable.
There is only one function for the whole binary. We don't need it to exist per instance. It still needs to be injected to prevent a direct dependency from the parser into the reflection runtime.
Also, move the check for GetMap/MutableMap to be inlined to avoid a regression in the table-driven parser.
Currently it goes through an indirect function call even if the field is clean
and needs no sync'n.