Adjustments to use existing deterministic deployment scripts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm not sure why tests are failing, probably because I adjusted the deploy which is part of the test setup task, but not sure. |
nick8319
reviewed
Jun 28, 2023
hardhat.config.ts
Outdated
| signedTx: info.transaction, | ||
| factory: "0x08feB4fEb4530ea74E03036277a878e4c4290B8C", | ||
| deployer: "<invalid>", | ||
| funding: "<invalid>", |
There was a problem hiding this comment.
Looks like tests failed due to the missing funding value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use hardhat-deploy based on Allow deterministic support for zkSync wighawag/hardhat-deploy#463
https://github.com/rmeissner/hardhat-deploy/tree/zksync_deterministicpackage.jsonto2.9.1(no>or^)yarn installyarn buildyarn linkUse
yarn link "hardhat-deploy"in safe-contract repo folder0x08feB4fEb4530ea74E03036277a878e4c4290B8Cis a singleton factory deployed on testnet