Merge pull request #466 from islishude/dont-check-no-empty-block-for-…

…receive-func disable no-empty-blocks for receive function
protofire · Aug 3, 2023 · 3810fc2 · 3810fc2
2 parents 1d89d69 + a676cf8
commit 3810fc2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/rules/best-practises/no-empty-blocks.js b/lib/rules/best-practises/no-empty-blocks.js
@@ -1,5 +1,5 @@
 const BaseChecker = require('../base-checker')
-const { isFallbackFunction } = require('../../common/ast-types')
+const { isFallbackFunction, isReceiveFunction } = require('../../common/ast-types')
 
 const ruleId = 'no-empty-blocks'
 const meta = {
@@ -50,8 +50,9 @@ class NoEmptyBlocksChecker extends BaseChecker {
     }
 
     const isFallbackFunctionBlock = isFallbackFunction(node.parent)
-    if (isFallbackFunctionBlock) {
-      // ignore empty blocks in fallback functions
+    const isReceiveFunctionBlock = isReceiveFunction(node.parent)
+    if (isFallbackFunctionBlock || isReceiveFunctionBlock) {
+      // ignore empty blocks in fallback or receive functions
       return
     }
     this._validateChildrenCount(node, 'statements')

diff --git a/test/rules/best-practises/no-empty-blocks.js b/test/rules/best-practises/no-empty-blocks.js
@@ -25,6 +25,8 @@ describe('Linter - no-empty-blocks', () => {
 
   const BLOCKS_WITH_DEFINITIONS = [
     contractWith('function () public payable { make1(); }'),
+    contractWith('receive() external payable {}'),
+    contractWith('fallback() external payable {}'),
     funcWith('if (a < b) { make1(); }'),
     contractWith('struct Abc { uint a; }'),
     contractWith('enum Abc { Test1 }'),