make no-unused-imports a recommended rule

protofire · Mar 9, 2023 · 3be5f80 · 3be5f80
1 parent 673bc11
commit 3be5f80
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/rules/best-practises/no-unused-import.js b/lib/rules/best-practises/no-unused-import.js
@@ -11,7 +11,7 @@ const meta = {
   },
 
   isDefault: false,
-  recommended: false,
+  recommended: true,
   defaultSetup: 'warn',
 
   schema: null,

diff --git a/test/rules/best-practises/no-unused-import.js b/test/rules/best-practises/no-unused-import.js
@@ -1,5 +1,10 @@
 const linter = require('../../../lib/index')
-const { assertNoErrors, assertErrorMessage, assertErrorCount } = require('../../common/asserts')
+const {
+  assertNoErrors,
+  assertErrorMessage,
+  assertErrorCount,
+  assertWarnsCount,
+} = require('../../common/asserts')
 
 describe('Linter - no-unused-import', () => {
   it('should raise when imported name is not used', () => {
@@ -12,6 +17,16 @@ describe('Linter - no-unused-import', () => {
     assertErrorMessage(report, 'imported name A is not used')
   })
 
+  it('should raise error when using solhint:recommended', () => {
+    const code = `pragma solidity ^0.5.8; import {A} from "./A.sol";`
+
+    const report = linter.processStr(code, {
+      extends: 'solhint:recommended',
+    })
+    assertWarnsCount(report, 1)
+    assertErrorMessage(report, 'imported name A is not used')
+  })
+
   it('should report correct name when unused import is aliased', () => {
     const code = `import {A as B} from './A.sol';`