fix: directories with .sol in the name path treated as files #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbale-altoros
force-pushed
the
fix/dirs-with-sol-extension
branch
from
df759a3
to
0ceb02b
Compare
dbale-altoros
force-pushed
the
fix/dirs-with-sol-extension
branch
2 times, most recently
from
d58e67f
to
93b9607
Compare
dbale-altoros
changed the title
dbale-altoros
force-pushed
the
fix/dirs-with-sol-extension
branch
from
93b9607
to
fca4956
Compare
dbale-altoros
force-pushed
the
fix/dirs-with-sol-extension
branch
from
fca4956
to
fdc962f
Compare
fvictorio
suggested changes
Jan 25, 2023
| @@ -1,12 +1,24 @@ | |||
| ## [3.3.9] - TBD | |||
There was a problem hiding this comment.
This change doesn't seem to belong to this PR.
There was a problem hiding this comment.
I corrected the old changelog and added this pr as well
The point is to have it up to date and update it on every change after this one
dbale-altoros
force-pushed
the
fix/dirs-with-sol-extension
branch
from
9c4688d
to
a71a19a
Compare
|
@fvictorio |
fvictorio
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds E2E tests for the pr #352
Credits to @pycckuu