fix: ordering-rule support for top level statements #393
Conversation
|
Custom errors can also be at the file-level (that is, outside a contract) and this PR doesn't handle that. |
dbale-altoros
changed the title
@fvictorio |
|
I don't remember, check the implementation. |
|
Added support for: At File Level:
At Contract Level:
|
dbale-altoros
changed the title
| uint256 constant oneNiceConstant = 1; | ||
| function freeFunction() pure returns (uint256) { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
@frangio sorry for the ping, but do you have an opinion on this order for file-level nodes? The new supported elements are custom errors, constants and functions.
I feel like I would swap constants and errors here, so that the order is:
- Constants
- Enum/Structs
- Custom errors
- Functions
- Contracts
Bikeshedding though.
There was a problem hiding this comment.
@fvictorio I feel the order you proposed is a better one
I changed the weight so it can match what you suggested
Please approve when you have time
dbale-altoros
changed the title
This is the #377 with unit tests addition to check the behavior
credits to @pahor167