New Rule: foundry test function names and other fixes #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbale-altoros
force-pushed
the
i402-foundry-test-function-names
branch
7 times, most recently
from
2ce9515
to
1ea6d35
Compare
dbale-altoros
force-pushed
the
i402-foundry-test-function-names
branch
from
1ea6d35
to
11b1a09
Compare
fiction-code
approved these changes
Aug 11, 2023
|
I always use the naming scheme test/CreateX.t.sol
50:5 warning Function testDeployCreatePayable() must match Foundry test naming convention foundry-test-functions
78:5 warning Function testDeployCreateZeroBytesNonPayable() must match Foundry test naming convention foundry-test-functions
83:5 warning Function testDeployCreateZeroBytesPayable() must match Foundry test naming convention foundry-test-functions
88:5 warning Function testDeployCreateRevertNonPayable() must match Foundry test naming convention foundry-test-functions
93:5 warning Function testDeployCreateRevertPayable() must match Foundry test naming convention foundry-test-functions
98:5 warning Function testFuzzDeployCreateNonPayable() must match Foundry test naming convention foundry-test-functions
128:5 warning Function testFuzzDeployCreatePayable() must match Foundry test naming convention foundry-test-functionsI don't think this should issue a warning tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rule described here:
#402
Also updated doc generator to write Notes on each rule if needed