-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: require the package with fullname #515
feat: require the package with fullname #515
Conversation
zouguangxian
commented
Oct 24, 2023
- supports require.resolve(package) in extends field
b780ac1
to
d6edd41
Compare
supports require.resolve(package) in extends field
d6edd41
to
06808b3
Compare
@zouguangxian thanks a lot for your PR Can you explain what this PR does and how is this useful ? |
In a monorepo, there will be a common practice of putting the shareable configuration in a package, e.g. @organize/solhint-config, then using this package in the solhint.config.js of individual package:
but it requires the package name should be like 'solhint:recommended' or 'solhint-config-${path}' in the configGetter function, so that '@organize/solhint-config' can not be supported. this patch will allow the developer to use the package in this way:
|
@zouguangxian thanks for the clarification Thanks a lot for your contribution We are planning a new version pretty soon... stay tuned... Join our discord: |
fixed, please review again. |