Fix exit codes and max-warnings on quiet #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbale-altoros
force-pushed
the
fix-exit-codes
branch
6 times, most recently
from
25c2ad2
to
1e65c0d
Compare
dbale-altoros
force-pushed
the
fix-exit-codes
branch
from
1e65c0d
to
0cec1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change in terms that the program changed how the exit codes are implemented
Solhint will exit with 0
when execution was ok and there were no errors when evaluating the code according to the rules
Solhint will exit with 1
when execution was ok and there are errors reported
when execution was ok and max warnings is lower than the reported warnings
Solhint will exit with 255
when there's an error in the execution (bad config, writing not allowed, wrong parameter, file not found, etc)
QUIET mode (-c quiet) option now works with the warnings and may exit with 1 if there are more than defined by user