Have --max-warnings better reflect its name #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solhint.js
Outdated
| @@ -17,7 +17,7 @@ function init() { | |||
| .option('-f, --formatter [name]', 'report formatter name (stylish, table, tap, unix)') | |||
| .option( | |||
| '-w, --max-warnings [maxWarningsNumber]', | |||
| 'number of warnings to trigger nonzero exit code' | |||
| 'number of allowed warnings to not trigger nonzero exit code' | |||
There was a problem hiding this comment.
Isn't something in the fashion of number of allowed warnings actually easier to read?
There was a problem hiding this comment.
I left the original comment about a nonzero exit code to avoid being too opinionated, but I do think your description should be enough.
There was a problem hiding this comment.
Nice. Let's aim for that then.
pablofullana
approved these changes
Dec 20, 2018
fvictorio
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a run with
--max-warnings 0always fails, andmax-warnings 1only succeeds if there are no warnings.I changed the behavior and updated the description to better reflect the expected behavior.