Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some comment directive tests. #92

Closed
wants to merge 1 commit into from
Closed

Fixed some comment directive tests. #92

wants to merge 1 commit into from

Conversation

nventuro
Copy link
Contributor

The assert statements checks for assertErrorCount(report, 1), but the disabled line is pragma solidity ^0.4.4;, which triggers a warning ('compiler version must be fixed'), not an error, so the test isn't really testing whether or not disable-next-line works.

This makes it so that both lines have an error.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.526% when pulling b963b98 on nventuro:directive-tests into f389547 on protofire:master.

@fvictorio
Copy link
Contributor

Makes sense. Maybe we can just add this as part of #91?

@nventuro
Copy link
Contributor Author

Done in 99efbf9

@nventuro nventuro closed this Dec 20, 2018
@nventuro nventuro deleted the directive-tests branch December 20, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants