Make String& parameters const String&, use JsonVariantConst::is/as<const char *>() #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
String&
parameter to the constructor andUUD::fromString()
aconst String&
- this allows xvalues to be passed to them.const char *
versions ofJsonVariantConst
'sis
andas
functions. The "plain"char *
versions were removed in ArduinoJson 6.20.I'm aware that a "proper" library update requires some additional housekeeping in library.json, but I didn't want to make any assumptions in how you'd like to implement that. Of course, I'm happy to take care of the chore if you would be willing to give some directions.