Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make String& parameters const String&, use JsonVariantConst::is/as<const char *>() #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rbergen
Copy link

@rbergen rbergen commented Jun 23, 2023

This:

  • Makes the String& parameter to the constructor and UUD::fromString() a const String& - this allows xvalues to be passed to them.
  • Switches to the const char * versions of JsonVariantConst's is and as functions. The "plain" char * versions were removed in ArduinoJson 6.20.

I'm aware that a "proper" library update requires some additional housekeeping in library.json, but I didn't want to make any assumptions in how you'd like to implement that. Of course, I'm happy to take care of the chore if you would be willing to give some directions.

@moritz89
Copy link
Contributor

Hi @rbergen, I'm a former developer at Protohaus, but the oss isn't maintained any more. If you post your own version, I'd be happy to contribute personal code that adds support for std::vector and co. as well as other functionality like ESP8266 support.

@rbergen
Copy link
Author

rbergen commented Jun 23, 2023

I'm a former developer at Protohaus, but the oss isn't maintained any more.

That's good to know.

I know this code is released under the MIT license so I think I know the answer to the next question, but in the interest of "better safe than sorry": is there any code I should take out of this implementation if I were to indeed post my own? (Actually, the code would be under the PlummersSoftwareLLC organization; we're likely to use this in its NightDriverStrip project.)

I'd be happy to contribute personal code that adds support for std::vector and co. as well as other functionality like ESP8266 support.

Thank you, I would appreciate that very much!

@moritz89
Copy link
Contributor

Cool project and nice use of Chrome's web serial API. AFAIK, you can basically republish the project, edit what you want and even relicence it as long as you keep the original LICENSE file as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants