Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE: SchemaRegistry references support #3747

Merged
merged 18 commits into from
Jul 12, 2023
Merged

BE: SchemaRegistry references support #3747

merged 18 commits into from
Jul 12, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Apr 27, 2023 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  1. references fields added to io dtos
  2. json schema references parsing fixed (using confluent JsonSchema)
  3. schema refs resolving added to ODD schema extractors

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner April 27, 2023 18:20
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Apr 27, 2023
@iliax iliax changed the title SchemaRegistry references support WIP: SchemaRegistry references support Apr 27, 2023
@iliax iliax changed the title WIP: SchemaRegistry references support SchemaRegistry references support Apr 27, 2023
@iliax iliax enabled auto-merge (squash) April 28, 2023 06:26
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean Haarolean linked an issue May 3, 2023 that may be closed by this pull request
SR: Support schema references #3768
Open
iliax and others added 10 commits June 22, 2023 11:53
Merge branch 'master' of github.com:provectus/kafka-ui into sr_refs_b…
e98bc4e 
…e_suport

� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/TopicsController.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/serdes/builtin/sr/SchemaRegistrySerde.java
merged with master
00d9f2a
compilation fix
559c484
@iliax
Merge branch 'master' into sr_refs_be_suport
70aee7c
@iliax
Merge branch 'master' into sr_refs_be_suport
9d6a6aa
Merge branch 'master' of github.com:provectus/kafka-ui into sr_refs_b…
6bab48b 
…e_suport

� Conflicts:
�	kafka-ui-api/src/test/java/com/provectus/kafka/ui/service/integration/odd/TopicsExporterTest.java
master merged
06425ba
tests fix
e64ea12
@iliax
Merge branch 'master' into sr_refs_be_suport
d5a2fd0
@iliax
Merge branch 'master' into sr_refs_be_suport
c255707
@Haarolean Haarolean self-requested a review July 12, 2023 10:46
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend and removed status/triage Issues pending maintainers triage labels Jul 12, 2023
@iliax iliax merged commit d4001b5 into master Jul 12, 2023
@iliax iliax deleted the sr_refs_be_suport branch July 12, 2023 10:47
@iliax iliax changed the title SchemaRegistry references support BE: SchemaRegistry references support Jul 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SR: Support schema references
2 participants
@iliax @Haarolean