update gradle/java/kotlin/grpc/proto #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,9 +72,9 @@ class ContractPluginIntegrationTest : WordSpec() { | |||
| cleanResult.task(":contracts:clean") shouldNot haveOutcome(TaskOutcome.FAILED) | |||
| p8eCleanResult.task(":p8eClean") should haveOutcome(TaskOutcome.SUCCESS) | |||
|
|
|||
| FileUtils.listFiles(File(contractPath), WildcardFileFilter("ContractHash*.kt"), WildcardFileFilter(".")) | |||
| FileUtils.listFiles(File(contractPath), WildcardFileFilter.builder().setWildcards("ContractHash*.kt").get(), WildcardFileFilter.builder().setWildcards(".").get()) | |||
There was a problem hiding this comment.
random deprecated stuff, good thing a builder for a simple value is so much more concise than a single constructor
| @@ -294,11 +294,11 @@ internal class Bootstrapper( | |||
| // filter out specifications that already exist | |||
| existingRecordSpecs.contains(functionSpec.outputSpec.spec.name) | |||
| }.forEach { functionSpec -> | |||
| val id = | |||
| val recordSpecId = | |||
There was a problem hiding this comment.
rando shadowed variable, just getting rid of a warning
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 7.19% 7.23% +0.04%
+ Complexity 6 3 -3
==========================================
Files 9 9
Lines 695 691 -4
Branches 62 59 -3
==========================================
Hits 50 50
+ Misses 643 639 -4
Partials 2 2
☔ View full report in Codecov by Sentry. |
mtps
approved these changes
Oct 18, 2023
cworsnop-figure
approved these changes
Oct 18, 2023
piercetrey-figure
deleted the
pierctrey-figure/sc-266198/update-gradle-grpc-java-etc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepping for updating to pb-grpc-client-kotlin
depends on provenance-io/p8e-scope-sdk#67