Fix most of the unit tests. #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions from the exchange module.
…t was added to make things compile, but is no longer needed since the rest of the functionality around it has been restored.
…pt getting wrong). Switch all uses of WaitForHeight to the testutil one.
…rn the one provided if the one provided doesn't have code 0.
…ew so that some trigger validate basic things can get the signers of messages. Fix the trigger unit tests.
…it has something in the raw log or somehow already has a Tx.
… the events that come back in a txResp. Create MutateGenesisState as an easier way to update a module's genesis state during test setup. Create createQueryCmd as a helper that will create a query command for a url. Create CmdGetAllGovProps that uses createQueryCmd to get all governance proposals.
… marker CLI tests.
… Fix marker keeper unit tests.
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 33 files out of 91 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…the provide msgType resolves to a msg (fixes the msgfees unit tests again).
…all required signers have sined a MsgAddNetAssetValuesRequest. The latter doesn't quite make sense for the error, and the former is what's used elsewhere in there.
… I switched to CLITxExecutor.
…f os stdout) so that we can hide all that output in unit tests.
…d tests quieter so that it's easier to find test failure info in the output.
…part, and split the rest among the other 3.
…Fix some import orderings.
Taztingo
previously approved these changes
Apr 24, 2024
…only log the output on the last attempt.
…ause TestSanctionValidatorImmediateUsingGovCmds keeps failing the race tests because the votes aren't coming in fast enough.
Taztingo
approved these changes
Apr 24, 2024
nullpointer0x00
approved these changes
Apr 25, 2024
|
This was part of the v0.50 updates |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes most of the CLI unit tests, and a lot of the other unit tests too.
Since most test are now fixed, this also tweaks the
testgithub action workflow to sort all the failing packages into03, and split the others among00-02. So after this is merged, I'll update the repo settings to require 0-2 to pass (instead of just making sure they build).Here's some info on the tests that still fail in this PR:
github.com/provenance-io/provenance/app- Need to fix the bank migration. Getting this panic from the umber upgrade tests:"parameter SendEnabled not registered"github.com/provenance-io/provenance/cmd/provenanced/cmd:cmd/provenanced/cmd/config_test.go- Need to update with updated config data.cmd/provenanced/cmd/pre_upgrade_test.go- There's a TODO in the RootCmd.PersistentPreRunE about the client context that I think is causing a test to fail here.github.com/provenance-io/provenance/internal/antewrapper- Still some TODOS left in here.github.com/provenance-io/provenance/x/ibchooks- These all fail with"tx parse error"indicating that some codec isn't being shared/used as expected.vendor/github.com/cosmos/cosmos-sdk/x/auth/tx/decoder.go: Error coming back from unknownproto.RejectUnknownFields:unable to resolve type URL /ibc.lightclients.tendermint.v1.ClientStateibctm "github.com/cosmos/ibc-go/v8/modules/light-clients/07-tendermint"module to the app so that the codec stuff is registered.transaction gas exceeds maximum allowed; got: 10000000 max allowed: 4000000: tx too largegit.luolix.top/provenance-io/provenance/x/ibcratelimit/module- "tx parse error"github.com/provenance-io/provenance/x/ibcratelimit/simulation- This fails because a msg that should be a gov prop is not being submitted as a gov prop.github.com/provenance-io/provenance/x/oracle/simulationTestSimulateMsgSendQueryOraclefails because the op msg is not okay. It has the comment "cannot get random channel because none exist".TestSimulateMsgUpdateOraclefails because a msg that should be a gov prop is not being submitted as a gov prop.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes