Add a bunch of new queries to the stargate whitelist. #2037
Conversation
WalkthroughThe changes encompass the augmentation and modification of queries within the stargate whitelist for numerous modules, including additions for modules such as Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (2)
internal/provwasm/stargate_whitelist.go (2)
80-92: The new queries added to thebankmodule are implemented correctly. It would be beneficial to ensure that the performance implications of these queries, especially those that could be heavy on data retrieval like/DenomOwnersByQuery, are considered.
[APROVED]Consider adding caching mechanisms or query optimizations for heavy data retrieval operations to improve performance.
158-160: Themintmodule queries have been added as per the requirements. It's advisable to monitor the performance of these queries, particularly/AnnualProvisions, due to its potential impact on system performance.Consider implementing performance monitoring tools to track the impact of new queries on system resources.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- internal/provwasm/stargate_whitelist.go (6 hunks)
Additional context used
Learnings (1)
internal/provwasm/stargate_whitelist.go (1)
User: Taztingo PR: provenance-io/provenance#2003 File: internal/provwasm/stargate_whitelist.go:86-87 Timestamp: 2024-05-24T17:54:44.729Z Learning: The new queries `QueryAttributeAccountsResponse` and `QueryAccountDataResponse` in the Attribute module are tested by their respective modules, as confirmed by the presence of these queries in various test files such as `x/attribute/keeper/query_server_test.go`, `x/attribute/client/rest/grpc_query_test.go`, and `x/attribute/client/cli/cli_test.go`.
Markdownlint
CHANGELOG.md
132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
147-147: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
148-148: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
149-149: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
150-150: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
151-151: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
152-152: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
153-153: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
154-154: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
155-155: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
156-156: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
251-251: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
252-252: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
253-253: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
254-254: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
255-255: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
256-256: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
257-257: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
286-286: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
287-287: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
288-288: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
376-376: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
377-377: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
378-378: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
379-379: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
380-380: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
381-381: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
383-383: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
384-384: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
385-385: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
386-386: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
387-387: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
743-743: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
751-751: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
796-796: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
804-804: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
850-850: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1251-1251: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1268-1268: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1320-1320: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1424-1424: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1246-1246: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
786-786: null (MD024, no-duplicate-heading)
Multiple headings with the same content
827-827: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1121-1121: null (MD024, no-duplicate-heading)
Multiple headings with the same content
261-261: null (MD034, no-bare-urls)
Bare URL used
292-292: null (MD034, no-bare-urls)
Bare URL used
391-391: null (MD034, no-bare-urls)
Bare URL used
441-441: null (MD034, no-bare-urls)
Bare URL used
453-453: null (MD034, no-bare-urls)
Bare URL used
469-469: null (MD034, no-bare-urls)
Bare URL used
540-540: null (MD034, no-bare-urls)
Bare URL used
551-551: null (MD034, no-bare-urls)
Bare URL used
559-559: null (MD034, no-bare-urls)
Bare URL used
595-595: null (MD034, no-bare-urls)
Bare URL used
620-620: null (MD034, no-bare-urls)
Bare URL used
632-632: null (MD034, no-bare-urls)
Bare URL used
678-678: null (MD034, no-bare-urls)
Bare URL used
679-679: null (MD034, no-bare-urls)
Bare URL used
680-680: null (MD034, no-bare-urls)
Bare URL used
681-681: null (MD034, no-bare-urls)
Bare URL used
682-682: null (MD034, no-bare-urls)
Bare URL used
729-729: null (MD034, no-bare-urls)
Bare URL used
770-770: null (MD034, no-bare-urls)
Bare URL used
823-823: null (MD034, no-bare-urls)
Bare URL used
936-936: null (MD034, no-bare-urls)
Bare URL used
978-978: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
978-978: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
374-374: null (MD038, no-space-in-code)
Spaces inside code span elements
Additional comments not posted (5)
internal/provwasm/stargate_whitelist.go (5)
62-62: All new queries under theauthmodule have been added correctly. Ensure that corresponding tests and documentation are updated to reflect these changes.Also applies to: 64-64, 66-66, 67-67, 68-68, 69-69, 70-70, 71-71
168-182: The comprehensive addition of staking-related queries is well done. Ensure that these additions are reflected in user-facing documentation and that they are included in regression tests.
103-112: The additions and modifications to thedistributionmodule queries are correct. Double-check that the changes are aligned with the latest module specifications and ensure comprehensive test coverage.
211-211: The new queries in theexchangemodule, especially those related to market commitments, are crucial for transaction integrity. Review the implementation for potential race conditions or data inconsistencies.
123-139: The government-related queries have been updated to include both v1beta1 and v1 versions. This is crucial for backward compatibility and future-proofing. Ensure that all these queries are thoroughly tested, especially for edge cases in governance voting and proposal mechanisms.Verification successful
The search results indicate that there are references to government-related queries (
QueryProposal,QueryProposals,QueryVote,QueryVotes,QueryParams,QueryDeposit,QueryDeposits,QueryTallyResult,QueryConstitution) within the test files. This suggests that these queries are indeed being tested.
QueryProposal,QueryProposals,QueryVote,QueryVotes,QueryParams,QueryDeposit,QueryDeposits,QueryTallyResult,QueryConstitutionare referenced in test files such as./testutil/queries/gov.go,./internal/provwasm/stargate_whitelist.go,./x/sanction/keeper/grpc_query_test.go, and others.Given this evidence, it appears that the new and modified government-related queries are covered by tests.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify test coverage for government-related queries. # Test: Search for test cases covering the new and modified gov queries. rg --type go $'gov.*Query' tests/Length of output: 81
Script:
#!/bin/bash # Description: Search for Go test files across the entire repository to locate where the tests are defined. # Find all Go test files in the repository fd --type f --extension go --exec grep -l 'func Test' {}Length of output: 7474
Script:
#!/bin/bash # Description: Verify test coverage for government-related queries within identified test files. # List of government-related queries to search for queries=( "QueryProposal" "QueryProposals" "QueryVote" "QueryVotes" "QueryParams" "QueryDeposit" "QueryDeposits" "QueryTallyResult" "QueryConstitution" ) # Search for references to government-related queries within the identified test files for query in "${queries[@]}"; do rg --type go "$query" ./x ./internal ./cmd ./app ./testutil doneLength of output: 64403
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- internal/provwasm/stargate_whitelist.go (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- internal/provwasm/stargate_whitelist.go
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (6)
CHANGELOG.md (6)
Line range hint
132-390: Consider using a consistent list marker style in Markdown to maintain uniformity and readability. The markdown linter has flagged multiple instances of inconsistent list style usage throughout the document.- - Add a bunch of queries to the stargate whitelist [#2037](https://github.com/provenance-io/provenance/pull/2037). + * Add a bunch of queries to the stargate whitelist [#2037](https://github.com/provenance-io/provenance/pull/2037).
Line range hint
853-853: There are multiple instances of consecutive blank lines which should be reduced to a single blank line for better readability and to adhere to Markdown practices.- - +Also applies to: 1254-1254, 1271-1271, 1323-1323, 1427-1427
Line range hint
981-981: There are spaces inside emphasis markers which should be removed to correct the Markdown formatting.- *Fixed* *spaces* + *Fixed* *spaces*
Line range hint
377-377: Spaces inside code span elements should be removed to correct the Markdown formatting.- ` code ` + `code`
Line range hint
789-789: Multiple headings with the same content have been used. Consider revising the headings to make them unique to improve document structure and navigation.Also applies to: 830-830, 1124-1124
Line range hint
264-264: Bare URLs have been used in the document. It's a good practice to link text rather than using bare URLs to improve readability and aesthetics of the document.- https://github.com/provenance-io/provenance/pull/2037 + [Provenance Pull Request #2037](https://github.com/provenance-io/provenance/pull/2037)Also applies to: 295-295, 394-394, 444-444, 456-456, 472-472, 543-543, 554-554, 562-562, 598-598, 623-623, 635-635, 681-685, 732-732, 773-773, 826-826, 939-939
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
Learnings (2)
Common learnings
User: iramiller PR: provenance-io/provenance#2037 File: internal/provwasm/stargate_whitelist.go:75-77 Timestamp: 2024-06-17T15:10:29.040Z Learning: Queries are explicitly added to the whitelist in `internal/provwasm/stargate_whitelist.go` because they are allowed to be used. If they were not listed, they would not be allowed, adhering to the security and deterministic execution requirements.CHANGELOG.md (1)
User: iramiller PR: provenance-io/provenance#2037 File: internal/provwasm/stargate_whitelist.go:75-77 Timestamp: 2024-06-17T15:10:29.040Z Learning: Queries are explicitly added to the whitelist in `internal/provwasm/stargate_whitelist.go` because they are allowed to be used. If they were not listed, they would not be allowed, adhering to the security and deterministic execution requirements.
Markdownlint
CHANGELOG.md
132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
133-133: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
134-134: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
135-135: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
142-142: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
143-143: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
144-144: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
147-147: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
148-148: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
149-149: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
150-150: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
151-151: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
152-152: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
153-153: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
154-154: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
155-155: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
156-156: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
157-157: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
158-158: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
159-159: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
251-251: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
252-252: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
253-253: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
254-254: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
255-255: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
256-256: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
257-257: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
258-258: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
259-259: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
260-260: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
289-289: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
290-290: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
291-291: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
368-368: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
369-369: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
370-370: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
371-371: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
372-372: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
373-373: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
374-374: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
376-376: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
377-377: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
378-378: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
379-379: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
380-380: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
381-381: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
382-382: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
383-383: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
384-384: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
385-385: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
386-386: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
387-387: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
388-388: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
389-389: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
390-390: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
746-746: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
754-754: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
799-799: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
807-807: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
853-853: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1254-1254: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1271-1271: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1323-1323: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1427-1427: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1249-1249: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
789-789: null (MD024, no-duplicate-heading)
Multiple headings with the same content
830-830: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1124-1124: null (MD024, no-duplicate-heading)
Multiple headings with the same content
264-264: null (MD034, no-bare-urls)
Bare URL used
295-295: null (MD034, no-bare-urls)
Bare URL used
394-394: null (MD034, no-bare-urls)
Bare URL used
444-444: null (MD034, no-bare-urls)
Bare URL used
456-456: null (MD034, no-bare-urls)
Bare URL used
472-472: null (MD034, no-bare-urls)
Bare URL used
543-543: null (MD034, no-bare-urls)
Bare URL used
554-554: null (MD034, no-bare-urls)
Bare URL used
562-562: null (MD034, no-bare-urls)
Bare URL used
598-598: null (MD034, no-bare-urls)
Bare URL used
623-623: null (MD034, no-bare-urls)
Bare URL used
635-635: null (MD034, no-bare-urls)
Bare URL used
681-681: null (MD034, no-bare-urls)
Bare URL used
682-682: null (MD034, no-bare-urls)
Bare URL used
683-683: null (MD034, no-bare-urls)
Bare URL used
684-684: null (MD034, no-bare-urls)
Bare URL used
685-685: null (MD034, no-bare-urls)
Bare URL used
732-732: null (MD034, no-bare-urls)
Bare URL used
773-773: null (MD034, no-bare-urls)
Bare URL used
826-826: null (MD034, no-bare-urls)
Bare URL used
939-939: null (MD034, no-bare-urls)
Bare URL used
981-981: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
981-981: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
377-377: null (MD038, no-space-in-code)
Spaces inside code span elements
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (6)
CHANGELOG.md (6)
Line range hint
207-233: Consider using a consistent list marker style in Markdown to maintain uniformity and readability. The markdown linter has flagged multiple instances of inconsistent list style usage throughout the document.- - Add a bunch of queries to the stargate whitelist [#2037](https://github.com/provenance-io/provenance/pull/2037). + * Add a bunch of queries to the stargate whitelist [#2037](https://github.com/provenance-io/provenance/pull/2037).Also applies to: 304-334, 364-366, 443-465, 821-821, 829-829, 874-874, 882-882
Tools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Line range hint
1324-1324: There's an issue with multiple spaces after the hash in an ATX style heading which can cause formatting issues in Markdown renderers.- ## This is a heading + ## This is a headingTools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Line range hint
864-864: Multiple headings with the same content can cause confusion and issues with navigation in the document. Consider revising the headings to make them unique or consolidating the sections if they are meant to cover the same content.Also applies to: 905-905, 1199-1199
Tools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Line range hint
339-339: Bare URLs are used in the document. It's recommended to link them using Markdown link syntax for better readability and accessibility.- https://github.com/provenance-io/provenance/pull/2037 + [PR #2037](https://github.com/provenance-io/provenance/pull/2037)Also applies to: 370-370, 469-469, 519-519, 531-531, 547-547, 618-618, 629-629, 637-637, 673-673, 698-698, 710-710, 756-756, 757-757, 758-758, 759-759, 760-760, 807-807, 848-848, 901-901, 1014-1014
Tools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Line range hint
1056-1056: Spaces found inside emphasis markers. This can lead to unintended display issues in Markdown renderers.- *This is ** not** correct* + *This is **not** correct*Tools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Line range hint
452-452: Spaces found inside code span elements. This can lead to unintended display issues in Markdown renderers.- ` code ` + `code`Tools
Markdownlint
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- internal/provwasm/stargate_whitelist.go (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- internal/provwasm/stargate_whitelist.go
Additional context used
Learnings (2)
Common learnings
User: iramiller PR: provenance-io/provenance#2037 File: internal/provwasm/stargate_whitelist.go:75-77 Timestamp: 2024-06-17T15:10:29.040Z Learning: Queries are explicitly added to the whitelist in `internal/provwasm/stargate_whitelist.go` because they are allowed to be used. If they were not listed, they would not be allowed, adhering to the security and deterministic execution requirements.CHANGELOG.md (1)
User: iramiller PR: provenance-io/provenance#2037 File: internal/provwasm/stargate_whitelist.go:75-77 Timestamp: 2024-06-17T15:10:29.040Z Learning: Queries are explicitly added to the whitelist in `internal/provwasm/stargate_whitelist.go` because they are allowed to be used. If they were not listed, they would not be allowed, adhering to the security and deterministic execution requirements.
Markdownlint
CHANGELOG.md
207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
212-212: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
213-213: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
214-214: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
223-223: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
224-224: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
225-225: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
304-304: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
305-305: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
306-306: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
307-307: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
308-308: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
309-309: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
310-310: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
311-311: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
312-312: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
313-313: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
315-315: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
316-316: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
317-317: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
318-318: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
319-319: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
320-320: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
321-321: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
323-323: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
324-324: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
325-325: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
326-326: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
327-327: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
328-328: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
329-329: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
332-332: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
333-333: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
334-334: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
335-335: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
443-443: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
444-444: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
445-445: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
446-446: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
448-448: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
449-449: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
450-450: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
451-451: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
452-452: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
453-453: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
454-454: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
461-461: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
462-462: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
463-463: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
821-821: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
829-829: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
874-874: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
882-882: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style
186-186: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
928-928: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1329-1329: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1346-1346: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1398-1398: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1502-1502: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1324-1324: null (MD019, no-multiple-space-atx)
Multiple spaces after hash on atx style heading
864-864: null (MD024, no-duplicate-heading)
Multiple headings with the same content
905-905: null (MD024, no-duplicate-heading)
Multiple headings with the same content
1199-1199: null (MD024, no-duplicate-heading)
Multiple headings with the same content
339-339: null (MD034, no-bare-urls)
Bare URL used
370-370: null (MD034, no-bare-urls)
Bare URL used
469-469: null (MD034, no-bare-urls)
Bare URL used
519-519: null (MD034, no-bare-urls)
Bare URL used
531-531: null (MD034, no-bare-urls)
Bare URL used
547-547: null (MD034, no-bare-urls)
Bare URL used
618-618: null (MD034, no-bare-urls)
Bare URL used
629-629: null (MD034, no-bare-urls)
Bare URL used
637-637: null (MD034, no-bare-urls)
Bare URL used
673-673: null (MD034, no-bare-urls)
Bare URL used
698-698: null (MD034, no-bare-urls)
Bare URL used
710-710: null (MD034, no-bare-urls)
Bare URL used
756-756: null (MD034, no-bare-urls)
Bare URL used
757-757: null (MD034, no-bare-urls)
Bare URL used
758-758: null (MD034, no-bare-urls)
Bare URL used
759-759: null (MD034, no-bare-urls)
Bare URL used
760-760: null (MD034, no-bare-urls)
Bare URL used
807-807: null (MD034, no-bare-urls)
Bare URL used
848-848: null (MD034, no-bare-urls)
Bare URL used
901-901: null (MD034, no-bare-urls)
Bare URL used
1014-1014: null (MD034, no-bare-urls)
Bare URL used
1056-1056: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
1056-1056: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers
452-452: null (MD038, no-space-in-code)
Spaces inside code span elements
Description
This PR adds a bunch of missing queries to the stargate whitelist.
To identify all of the queries that are possible, I put together this bash command:
Then, to identify which ones we have whitelisted, I used this command:
Then, to find what's missing (or wrong), I just did this:
Here are the ones I didn't add, and why:
"/cosmos.app.v1alpha1.Query/Config" QueryConfigResponse- It's alpha, and I don't think it's an exposed query."/cosmos.autocli.v1.Query/AppOptions" AppOptionsResponse- I don't think this is an exposed query.cosmos.orm.*- I don't think these are exposed./cosmos.nft.*- We don't have the nft module (yet).cosmos.params.*- We just moved everything out of the params module and will be removing it in v1.20 (hopefully). Might as well leave these out."/cosmos.upgrade.v1beta1.Query/UpgradedConsensusState" QueryUpgradedConsensusStateResponse- Deprecated and already replaced with something else (see comment on it in the proto).cosmwasm.wasm.*- I wasn't sure what (if anything) we wanted from here. I'll post the full list below.ibc.*- There's a bunch of ibc-related queries, and I'm not sure which ones it makes sense to include. I'll post the full list below.Here are all the wasm queries. We haven't whitelisted any of these:
And here are all the ibc queries that haven't been whitelisted:
The only ibc query that we do have whitelisted is
"/ibc.applications.transfer.v1.Query/DenomTrace", QueryDenomTraceResponseBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
authz,bank,circuit,consensus,distribution,evidence,feegrant,gov,group,mint,slashing,staking,upgrade, and Provenance-specific modules.authanddistributionmodules to enhance functionality.