-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5 #2153
Bump cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5 #2153
Conversation
Bumps [cosmossdk.io/client/v2](https://github.com/cosmos/cosmos-sdk) from 2.0.0-beta.4 to 2.0.0-beta.5. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@client/v2.0.0-beta.4...client/v2.0.0-beta.5) --- updated-dependencies: - dependency-name: cosmossdk.io/client/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ere's a new proofs.proto file.
Ugh... Breaking 3rd party protobuf change due to the bump in
I'm not sure what we can do about that, so I'm gonna hold off on this PR for a bit. There's a good chance that we just accept it and move forward, but we need to consider the ramifications first. |
Created cosmos/ics23#376 to let them know about the breaking change. We'll wait on that a bit before deciding what to do here. |
Two things combine to make it very likely that this won't cause a problem:
Also, there isn't really a way to fix this since the updated proto is already out there; changing it back would cause another breaking change for anyone using this version. So we really only have two options:
Option 1 seems like the only realistic option to me, so I suggest we approve and merge this PR. |
Bumps cosmossdk.io/client/v2 from 2.0.0-beta.4 to 2.0.0-beta.5.
Commits
25255e4
feat(client/v2): use x/txAminoNameAsTypeURL
option in 0.50 (#21801)7ee3115
feat(x/tx): addaminoNameAsTypeURL
option in aminojson encoder (backport #2...f812291
chore: prepare v0.50.10 (#21498)b2ec2f6
fix(runtime): fix option order (backport #21769) (#21771)9a0a76f
docs(x/circuit): display correct example (backport #21768) (#21773)3feb2c0
docs: demonstrate how to wire custom ante handlers in 0.50 app_di (#21767)b21441c
feat(types/collections): addLegacyDec
collection value (backport #21693) (...f78ed49
feat(x/genutil): add better error messages for genesis validation (backport #...fe37dfb
docs(x/authz): update grant docs (backport #21677) (#21700)ef8a575
docs(client/debug): correctdebug raw-bytes
command example (backport #2167...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)