-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #407 from zfLQ2qx2/prowler_misc_fixes
Misc prowler fixes Add GetEbsEncryptionByDefault wherever Prowler policies are mentioned Update Extra718 check to be aware of access denied responses Update Extra726 check to be more verbose for non-failure items Update Extra73 check to be aware of access denied responses Update Extra734 check to be aware of access denied responses and parse policies with jq for better accuracy Update Extra742 check for verbiage Update Extra756 check for verbiage and parameter order Update Extra761 check for failure scenarios (requires most recent awscli and addition to Prowler IAM policy) Added Extra763 check to verify that object versioning is enabled on S3 buckets Added Extra764 check to verify that S3 buckets enforce a secure transport policy
- Loading branch information
Showing
14 changed files
with
188 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Prowler - the handy cloud security tool (copyright 2018) by Toni de la Fuente | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
# use this file except in compliance with the License. You may obtain a copy | ||
# of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software distributed | ||
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR | ||
# CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations under the License. | ||
CHECK_ID_extra763="7.63" | ||
CHECK_TITLE_extra763="[extra763] Check if S3 buckets have object versioning enabled (Not Scored) (Not part of CIS benchmark)" | ||
CHECK_SCORED_extra763="NOT_SCORED" | ||
CHECK_TYPE_extra763="EXTRA" | ||
CHECK_ALTERNATE_check763="extra763" | ||
|
||
extra763(){ | ||
# "Check if S3 buckets have object versioning enabled (Not Scored) (Not part of CIS benchmark)" | ||
LIST_OF_BUCKETS=$($AWSCLI s3api list-buckets $PROFILE_OPT --query Buckets[*].Name --output text|xargs -n1) | ||
if [[ $LIST_OF_BUCKETS ]]; then | ||
for bucket in $LIST_OF_BUCKETS;do | ||
BUCKET_VERSIONING_ENABLED=$($AWSCLI s3api get-bucket-versioning --bucket $bucket $PROFILE_OPT --query Status --output text 2>&1) | ||
if [[ $(echo "$BUCKET_VERSIONING_ENABLED" | grep AccessDenied) ]]; then | ||
textFail "Access Denied Trying to Get Bucket Versioning for $bucket" | ||
continue | ||
fi | ||
if [[ $(echo "$BUCKET_VERSIONING_ENABLED" | grep "^Enabled$") ]]; then | ||
textPass "Bucket $bucket has versioning enabled" | ||
else | ||
textFail "Bucket $bucket has versioning disabled!" | ||
fi | ||
done | ||
else | ||
textInfo "No S3 Buckets found" | ||
fi | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Prowler - the handy cloud security tool (copyright 2018) by Toni de la Fuente | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
# use this file except in compliance with the License. You may obtain a copy | ||
# of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software distributed | ||
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR | ||
# CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations under the License. | ||
CHECK_ID_extra764="7.64" | ||
CHECK_TITLE_extra764="[extra764] Check if S3 buckets have secure transport policy (Not Scored) (Not part of CIS benchmark)" | ||
CHECK_SCORED_extra764="NOT_SCORED" | ||
CHECK_TYPE_extra764="EXTRA" | ||
CHECK_ALTERNATE_check764="extra764" | ||
|
||
extra764(){ | ||
LIST_OF_BUCKETS=$($AWSCLI s3api list-buckets $PROFILE_OPT --query Buckets[*].Name --output text|xargs -n1) | ||
if [[ $LIST_OF_BUCKETS ]]; then | ||
for bucket in $LIST_OF_BUCKETS;do | ||
TEMP_STP_POLICY_FILE=$(mktemp -t prowler-${ACCOUNT_NUM}-${bucket}.policy.XXXXXXXXXX) | ||
|
||
# get bucket policy | ||
$AWSCLI s3api get-bucket-policy $PROFILE_OPT --bucket $bucket --output text --query Policy > $TEMP_STP_POLICY_FILE 2>&1 | ||
if [[ $(grep AccessDenied $TEMP_STP_POLICY_FILE) ]]; then | ||
textFail "Access Denied Trying to Get Bucket Policy for $bucket" | ||
continue | ||
fi | ||
if [[ $(grep NoSuchBucketPolicy $TEMP_STP_POLICY_FILE) ]]; then | ||
textFail "No bucket policy for $bucket" | ||
continue | ||
fi | ||
|
||
# check if the S3 policy denies all actions by all principals when aws:SecureTransport:false | ||
CHECK_BUCKET_STP_POLICY_PRESENT=$(cat $TEMP_STP_POLICY_FILE | jq --arg arn "arn:aws:s3:::${bucket}/*" '.Statement[]|select(.Effect=="Deny" and (.Principal|type == "object") and .Principal.AWS == "*" and .Action=="s3:*" and .Resource==$arn and .Condition.Bool."aws:SecureTransport" == "false")') | ||
if [[ $CHECK_BUCKET_STP_POLICY_PRESENT ]]; then | ||
textPass "Bucket $bucket has S3 bucket policy to deny requests over insecure transport" | ||
else | ||
textFail "Bucket $bucket allows requests over insecure transport" | ||
fi | ||
|
||
rm -fr $TEMP_STP_POLICY_FILE | ||
done | ||
|
||
else | ||
textInfo "No S3 Buckets found" | ||
fi | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.