Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(k8s): Add helm-chart #4370

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

shot4free
Copy link
Contributor

Context

Adding a helm chart for prowler as discussed here: #4358 (comment)

Description

Simple helm chart to deploy prowler for k8s.
Implemented additional logics for GKE as one of the paths (/srv/kubernetes) cannot be mounted in GCP clusters.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shot4free shot4free requested review from a team July 3, 2024 12:17
@jfagoagas jfagoagas changed the title Adds helm-chart for prowler chore(k8s): Add helm-chart Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (040e1ea) to head (b50b872).
Report is 503 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4370      +/-   ##
==========================================
+ Coverage   87.39%   87.46%   +0.07%     
==========================================
  Files         849      853       +4     
  Lines       26495    26591      +96     
==========================================
+ Hits        23155    23258     +103     
+ Misses       3340     3333       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec self-assigned this Jul 3, 2024
MrCloudSec

This comment was marked as duplicate.

@MrCloudSec MrCloudSec self-requested a review July 3, 2024 18:05
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this @shot4free , thanks!!
Could you add the steps to deploy the helm chart in the README? That would be so helpful.

@shot4free
Copy link
Contributor Author

Love this @shot4free , thanks!! Could you add the steps to deploy the helm chart in the README? That would be so helpful.

Done.

@jfagoagas jfagoagas requested a review from MrCloudSec July 4, 2024 06:57
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shot4free !

@MrCloudSec MrCloudSec merged commit e387c59 into prowler-cloud:master Jul 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants