Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional error checking to check extra769 #444

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

zfLQ2qx2
Copy link
Contributor

Add additional error checking to check extra769

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zfLQ2qx2
Copy link
Contributor Author

@toniblyx I've raised a new PR for Prowler

@toniblyx
Copy link
Member

cool, thanks! I'm working on a new function to check AWS CLI version, let me finish it and we can probably add more context to that message.

@zfLQ2qx2
Copy link
Contributor Author

@toniblyx I thought about doing something like that, I could see gating each check individually on the minimum version needed to run it. I could also see doing a minimum version to run prowler and letting people know if their awscli is backlevel or not.

@toniblyx
Copy link
Member

I'm going to create an issue to track that AWS CLI version discussion and share what I got so far.

@toniblyx toniblyx merged commit a755ec8 into prowler-cloud:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants