Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prowler-check-kreator): ProwlerChecKreator first version #5099

Merged
merged 23 commits into from
Nov 12, 2024
Merged

feat(prowler-check-kreator): ProwlerChecKreator first version #5099

merged 23 commits into from
Nov 12, 2024

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Sep 19, 2024

Context

I created a script that helps to create checks with AI (Gemini for now).

Description

Added some scripts in utils.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22
feat(prowler-check-kreator): first ProwlerCheckKreator version
91f079b 
this is an script that helps to create checks with AI
@puchy22 puchy22 requested review from a team as code owners September 19, 2024 15:45
@puchy22 puchy22 marked this pull request as draft September 19, 2024 15:45
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (e778444) to head (5e77655).
Report is 116 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5099      +/-   ##
==========================================
+ Coverage   89.71%   89.89%   +0.18%     
==========================================
  Files        1086     1122      +36     
  Lines       33619    34782    +1163     
==========================================
+ Hits        30160    31267    +1107     
- Misses       3459     3515      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puchy22 puchy22 changed the title feat(prowler-check-kreator): first ProwlerCheckKreator version feat(prowler-check-kreator): first ProwlerChecKreator version Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@puchy22 puchy22 marked this pull request as ready for review September 20, 2024 14:19
@puchy22 puchy22 changed the title feat(prowler-check-kreator): first ProwlerChecKreator version feat(prowler-check-kreator): ProwlerChecKreator first version Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

You can check the documentation for this PR here -> Prowler Documentation

@MrCloudSec MrCloudSec force-pushed the PRWLR-4864-add-mkcheck-script-to-public-repo branch from 9baaf3e to 39a3526 Compare November 7, 2024 17:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

You can check the documentation for this PR here -> Prowler Documentation

@MrCloudSec MrCloudSec force-pushed the PRWLR-4864-add-mkcheck-script-to-public-repo branch from 39a3526 to 33a258a Compare November 7, 2024 17:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

You can check the documentation for this PR here -> Prowler Documentation

MrCloudSec
MrCloudSec requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do the following changes:

  • Add the required Python library to the documentation.

  • Fix -> Error: cannot access local variable ‘test_template’ when it has not been assigned a value.

  • Rearrange questions and simplify them: "Do you want to use AI?" -> "Which model?" -> "Do you want to overwrite existing files?"

  • Automatically include 10 reference examples by default, rather than relying on the user to provide them.

  • Add support for additional providers.

  • If the GEMINI_API_KEY environment variable is not set, prompt the user to enter it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

You can check the documentation for this PR here -> Prowler Documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

You can check the documentation for this PR here -> Prowler Documentation

@MrCloudSec MrCloudSec self-requested a review November 12, 2024 19:59
MrCloudSec
MrCloudSec approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it @puchy22 !!

@MrCloudSec MrCloudSec merged commit b8b60e6 into master Nov 12, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4864-add-mkcheck-script-to-public-repo branch November 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCloudSec MrCloudSec MrCloudSec approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puchy22 @MrCloudSec