Find trust boundaries in VPC endpoint services #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toniblyx
requested changes
Mar 5, 2020
There was a problem hiding this comment.
Thanks @renuez, let me add here some comments and changes I would suggest to make before merging your code:
$ACCOUNT_NUMis a variable already set that you can use instead of$THIS_ACCOUNT_ID.- Could you comment the code? Some parts are self explanatory but others are less easy to understand, at least for me. That will help others to improve it and create other checks based on these ones.
- It would be also helpful to add information about the use case in the comments as well as the syntax for the whitelist files. Btw, why not to have comma separated values in a variable inside the check file? or an array?
toniblyx
requested changes
Mar 5, 2020
…vices whitelisted principles)
Merge latest master from prowler
|
@toniblyx Thanks for your recent feedback and code review support. |
|
This pull request has been already applied, I had to do a workaround with conflicts. Thanks @renuez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
It's my first proposal on a series of potential new checks that find trust boundaries in VPC endpoint services (whitelisted principals and connections).
I do also have one for VPC peerings and I currently work on another one for IAM roles.
I think there are many interesting use cases to compare a known whitelist of accounts against KMS usage/admin policies, S3 bucket policies or ACLs, ...
Maybe it's only interesting for multi-account setups with density and cohesion of AWS account trusts - what do you think of a dedicated new check group?