Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kinesis): add new check kinesis_stream_data_retention_period #5547

Conversation

HugoPBrito
Copy link
Member

@HugoPBrito HugoPBrito commented Oct 28, 2024

Context

In Amazon Kinesis Data Streams, each data stream consists of a sequence of records organized into shards, designed for high-throughput, real-time data ingestion and processing. To manage data accessibility, Kinesis Data Streams allows setting a data retention period (the time for which a record is accessible in the stream before it’s permanently removed).

Description

This check ensures that an Amazon Kinesis data stream has a data retention period equal to or longer than the required timeframe. If the stream’s data retention period is shorter than specified, the check fails, indicating that data could be removed too early, potentially hindering data continuity or recovery capabilities.

The minimum horus can be modified through min_kinesis_stream_retention_period in config.yaml file.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners October 28, 2024 16:34
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (3608aa3) to head (33a6374).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5547      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.04%     
==========================================
  Files        1128     1132       +4     
  Lines       35180    35275      +95     
==========================================
+ Hits        31631    31703      +72     
- Misses       3549     3572      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review my comments.

@MrCloudSec MrCloudSec self-requested a review November 14, 2024 15:45
@MrCloudSec MrCloudSec merged commit 7a71109 into master Nov 14, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5027-kinesis-streams-should-have-an-adequate-data-retention-period branch November 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants