-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kinesis): add new check kinesis_stream_data_retention_period
#5547
feat(kinesis): add new check kinesis_stream_data_retention_period
#5547
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5547 +/- ##
==========================================
- Coverage 89.91% 89.87% -0.04%
==========================================
Files 1128 1132 +4
Lines 35180 35275 +95
==========================================
+ Hits 31631 31703 +72
- Misses 3549 3572 +23 ☔ View full report in Codecov by Sentry. |
…adequate-data-retention-period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, review my comments.
Context
In
Amazon Kinesis Data Streams
, each datastream
consists of a sequence of records organized into shards, designed for high-throughput, real-time data ingestion and processing. To manage data accessibility, Kinesis Data Streams allows setting adata retention period
(the time for which a record is accessible in the stream before it’s permanently removed).Description
This check ensures that an
Amazon Kinesis data stream
has adata retention period
equal to or longer than the required timeframe. If the stream’s data retention period is shorter than specified, the check fails, indicating that data could be removed too early, potentially hindering data continuity or recovery capabilities.The minimum horus can be modified through
min_kinesis_stream_retention_period
inconfig.yaml
file.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.