-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dms): add new check dms_endpoint_redis_tls_enabled
#5583
Merged
MrCloudSec
merged 7 commits into
master
from
PRWLR-4475-ensure-dms-endpoints-for-redis-have-tls-enabled
Nov 6, 2024
Merged
feat(dms): add new check dms_endpoint_redis_tls_enabled
#5583
MrCloudSec
merged 7 commits into
master
from
PRWLR-4475-ensure-dms-endpoints-for-redis-have-tls-enabled
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Oct 30, 2024
danibarranqueroo
changed the title
feat(rds): add new check
feat(dms): add new check Oct 30, 2024
dms_endpoint_redis_tls_enabled
dms_endpoint_redis_tls_enabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5583 +/- ##
==========================================
- Coverage 89.88% 89.82% -0.07%
==========================================
Files 1114 1116 +2
Lines 34536 34578 +42
==========================================
+ Hits 31044 31061 +17
- Misses 3492 3517 +25 ☔ View full report in Codecov by Sentry. |
MrCloudSec
reviewed
Nov 5, 2024
...aws/services/dms/dms_endpoint_redis_tls_enabled/dms_endpoint_redis_tls_enabled.metadata.json
Outdated
Show resolved
Hide resolved
MrCloudSec
reviewed
Nov 5, 2024
MrCloudSec
reviewed
Nov 5, 2024
...aws/services/dms/dms_endpoint_redis_tls_enabled/dms_endpoint_redis_tls_enabled.metadata.json
Outdated
Show resolved
Hide resolved
MrCloudSec
approved these changes
Nov 6, 2024
MrCloudSec
deleted the
PRWLR-4475-ensure-dms-endpoints-for-redis-have-tls-enabled
branch
November 6, 2024 16:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new check verifies whether AWS Database Migration Service (DMS) endpoints for Redis are configured with TLS (Transport Layer Security). The control fails if TLS is not enabled for the endpoint.
TLS provides end-to-end encryption for data in transit, ensuring secure communication between source and target databases during migration. Enabling TLS helps prevent unauthorized access to sensitive data, mitigating risks such as data breaches and interception.
RDS endpoints have a parameter inside the Redis Settings called SslSecurityProtocol. This allows to enable or disable the connection to a Redis target endpoint using Transport Layer Security (TLS). Valid values include plaintext and ssl-encryption. The default is ssl-encryption. The ssl-encryption option makes an encrypted connection.
Description
Added new check
dms_endpoint_redis_tls_enabled
with its unit tests.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.