Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicecatalog): Add new check servicecatalog_portfolio_shared_within_organization_only #5632

Conversation

MarioRgzLpz
Copy link
Member

Context

Added a new check within the Service Catalog framework to ensures that portfolios are shared only within an AWS Organization if Organizations is enabled. The control will fail if a portfolio is being shared with an account while Organizations is active.

Description

Added check servicecatalog_portfolio_shared_within_organization_only with respective unit tests and metadata.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners November 4, 2024 19:22
Base automatically changed from PRWLR-4271-add-new-service-catalog-check-for-portfolio-sharing-within-aws-organization to master November 6, 2024 17:02
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (a2dba30) to head (0a41bf1).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
.../services/servicecatalog/servicecatalog_service.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5632      +/-   ##
==========================================
+ Coverage   89.84%   89.91%   +0.06%     
==========================================
  Files        1118     1124       +6     
  Lines       34664    34812     +148     
==========================================
+ Hits        31144    31301     +157     
+ Misses       3520     3511       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MrCloudSec
MrCloudSec previously approved these changes Nov 6, 2024
@MrCloudSec MrCloudSec merged commit 716558f into master Nov 8, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4272-service-catalog-new-check-for-portfolio-sharing-within-aws-organization branch November 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants