fix(ec2): unique finding per Security Group in high risk ports check #5697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An issue was detected within
ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports
check because it loops over a list of ports and all the findings are generated with the same finding.uid which can’t be a possibility.Description
Changed
ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports
logic to create one finding per security group instead of one finding per high risk port.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.