Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): unique finding per Security Group in high risk ports check #5697

Conversation

MarioRgzLpz
Copy link
Member

Context

An issue was detected within ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports check because it loops over a list of ports and all the findings are generated with the same finding.uid which can’t be a possibility.

Description

Changed ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports logic to create one finding per security group instead of one finding per high risk port.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarioRgzLpz MarioRgzLpz requested review from a team as code owners November 8, 2024 18:13
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (716558f) to head (0511dab).
Report is 764 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5697   +/-   ##
=======================================
  Coverage   89.93%   89.94%           
=======================================
  Files        1124     1124           
  Lines       34812    34815    +3     
=======================================
+ Hits        31309    31315    +6     
+ Misses       3503     3500    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

@MrCloudSec MrCloudSec changed the title fix(ec2): change ec2_securitygroup_allow_ingress_from_internet_to_high_risk_tcp_ports check fix(ec2): unique finding per Security Group in high risk ports check Nov 8, 2024
@MrCloudSec MrCloudSec merged commit 5de13bd into master Nov 8, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5244-ensure-that-check-findings-do-not-share-same-finding-uid branch November 8, 2024 19:08
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Nov 8, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jfagoagas jfagoagas added the backport-to-v4.5 Backport PR to the v4.5 branch label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.5 Backport PR to the v4.5 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants