Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): remove cloudwatch_log_group_no_critical_pii_in_logs check #5736

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

MrCloudSec
Copy link
Member

Description

Remove check cloudwatch_log_group_no_critical_pii_in_logs since presidio-analyzer is downloading a package during Prowler execution.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners November 12, 2024 16:12
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels Nov 12, 2024
@MrCloudSec MrCloudSec changed the title fix(aws): remove cloudwatch_log_group_no_critical_pii_in_logs check fix(aws): remove cloudwatch_log_group_no_critical_pii_in_logs check Nov 12, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing the check cloudwatch_log_group_no_critical_pii_in_logs for the following reasons:

  • It uses the presidio-analyzer library which by default loads during runtime the NLP module and other PII recognizers from external sources not defined in the Prowler dependencies. That's something we could not do as a security product taking also into account that Prowler can run in environments with little to zero access to the Internet.
  • Those dependencies cannot be installed via poetry since they are not available in PyPI and would require adding more steps to our installation procedure to get them.
  • The NLP module installed, en-core-web-lg is a large vector table with ~500k entries with a size of 400MiB. This is a huge package to be donwloaded during runtime.
  • The installation procedure of the above dependencies adds several lines to our terminal UI with the download process and some logs.
  • presidio-analyzer requires a ton of new libraries that we need to review first.

We will work to reintroduce the cloudwatch_log_group_no_critical_pii_in_logs in a way that all dependencies are explicitly defined, required and verified.

poetry.lock Show resolved Hide resolved
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@MrCloudSec MrCloudSec requested a review from jfagoagas November 12, 2024 17:03
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (c434181) to head (1688232).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5736      +/-   ##
==========================================
+ Coverage   89.88%   89.91%   +0.03%     
==========================================
  Files        1128     1127       -1     
  Lines       35182    35123      -59     
==========================================
- Hits        31622    31580      -42     
+ Misses       3560     3543      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit f133419 into master Nov 12, 2024
12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5341-create-fix-release-4-5-2-master branch November 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants