Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(documentdb): add new fixer documentdb_cluster_public_snapshot_fixer #5759

Conversation

danibarranqueroo
Copy link
Member

@danibarranqueroo danibarranqueroo commented Nov 13, 2024

Context

Developed a new fixer that modifies DocumentDB cluster snapshots to restrict public accessibility, ensuring that snapshots are private and only accessible within authorized accounts or VPCs. This fixer will prevent unauthorized access to DocumentDB backups and secure sensitive data stored in snapshots.

As moto does not cover this DocumentDB API calls I needed to use Botocore for the unit tests.

Description

Added new fixer documentdb_cluster_public_snapshot_fixer with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners November 13, 2024 19:34
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (794268c) to head (b582e81).
Report is 61 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5759    +/-   ##
========================================
  Coverage   89.87%   89.88%            
========================================
  Files        1128     1133     +5     
  Lines       35181    35285   +104     
========================================
+ Hits        31620    31715    +95     
- Misses       3561     3570     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MrCloudSec MrCloudSec merged commit 6811a22 into master Nov 22, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5297-set-document-db-manual-cluster-snapshot-as-not-public branch November 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants