Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compliance): use subscriptionid instead of name for azure cis #5786

Conversation

pedrooot
Copy link
Member

Description

This pull request includes changes to the prowler/lib/outputs/compliance/cis/cis_azure.py file and related test files to update the field name from Subscription to SubscriptionId in the AzureCISModel. This change ensures consistency in the naming convention across the codebase.

Key changes include:

  • Updated AzureCISModel to use SubscriptionId instead of Subscription in prowler/lib/outputs/compliance/cis/cis_azure.py [1] [2].
  • Modified the AzureCISModel class definition to reflect the new field name in prowler/lib/outputs/compliance/cis/models.py.
  • Adjusted test cases to use SubscriptionId instead of Subscription in tests/lib/outputs/compliance/cis/cis_azure_test.py [1] [2].
  • Updated the expected CSV output in the test case to match the new field name in tests/lib/outputs/compliance/cis/cis_azure_test.py.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners November 15, 2024 12:41
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (b6c8adf) to head (c0c6f53).
Report is 718 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5786      +/-   ##
==========================================
- Coverage   89.88%   89.86%   -0.02%     
==========================================
  Files        1132     1132              
  Lines       35275    35275              
==========================================
- Hits        31708    31701       -7     
- Misses       3567     3574       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas added compliance Issues/PRs related with the Compliance Frameworks backport-to-v4.5 labels Nov 15, 2024
@jfagoagas jfagoagas merged commit 8be83fc into master Nov 15, 2024
12 of 13 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5381-change-subscription-to-subscription-id-in-cis-for-azure branch November 15, 2024 13:40
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Nov 15, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jfagoagas jfagoagas added the backport-to-v4.5 Backport PR to the v4.5 branch label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.5 Backport PR to the v4.5 branch compliance Issues/PRs related with the Compliance Frameworks was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants