Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kms): add new fixer kms_cmk_not_deleted_unintentionally_fixer #5842

Conversation

danibarranqueroo
Copy link
Member

@danibarranqueroo danibarranqueroo commented Nov 20, 2024

Context

Developed a new fixer that reviews pending deletion requests for KMS CMKs and cancel the deletion. This helps prevent accidental loss of access to encrypted data, protecting against potential data loss and ensuring business continuity.

Description

Added new fixer kms_cmk_not_deleted_unintentionally_fixer with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners November 20, 2024 12:25
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (b06e549) to head (8e4d945).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5842   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files        1133     1134    +1     
  Lines       35319    35329   +10     
=======================================
+ Hits        31743    31753   +10     
  Misses       3576     3576           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@MrCloudSec MrCloudSec merged commit 861fb22 into master Nov 21, 2024
11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5327-aws-kms-keys-should-not-be-deleted-unintentionally branch November 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants