Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early #60

Merged
merged 4 commits into from
Jul 12, 2017
Merged

Fail early #60

merged 4 commits into from
Jul 12, 2017

Conversation

MrSecure
Copy link
Contributor

Exit the script immediately if unable to get-caller-identity - this indicates an issue with the credentials (invalid key, typo in ~/.aws/credentials, etc).

For listing topic subscribers, detect a permission failure, and fall back to showing counts of SNS topics by region, rather than subscriber details. This works around the missing permission in the AWS Managed "SecurityAudit" policy.

Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes make sense to me

@toniblyx toniblyx merged commit 55ed127 into prowler-cloud:master Jul 12, 2017
@MrSecure MrSecure deleted the fail-early branch July 12, 2017 15:38
@MrSecure MrSecure restored the fail-early branch July 12, 2017 15:41
@MrSecure MrSecure deleted the fail-early branch July 12, 2017 15:42
snaow pushed a commit that referenced this pull request Nov 25, 2024
snaow pushed a commit that referenced this pull request Nov 25, 2024
…lready exists (#60)

* fix(serializers): PRWLR-4869 hide email address information when it already exists

* fix(serializers): PRWLR-4869 fix ruff format error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants