-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check only for outdated root dependencies in Cargo checks. #73
Check only for outdated root dependencies in Cargo checks. #73
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
76b56ea
to
2b34605
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks! I have similar change in my local tree, so this looks good, but you need to sign the CLA before I can approve this. Also, could you please split this into 2 separate PRs (one with |
2b34605
to
3a8a5c7
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Signed-off-by: Takaya Saeki <takaya@tetrate.io>
3a8a5c7
to
7622a26
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for signing the CLA! Could you open the other PR as well? Thanks! |
@googlebot I signed it! |
Thanks so much for your review, Piotr! I've split this PR and opened another one. Although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…m#73) Signed-off-by: Takaya Saeki <takaya@tetrate.io>
…m#73) Signed-off-by: Takaya Saeki <takaya@tetrate.io>
This PR makes
cargo outdated
check only direct dependencies only in CI.Currently, CI also checks the versions of all dependencies in the dependency chain of the crates that
proxy-wasm-rust-sdk
depends on, and fails if it finds an outdated one. However, they are not direct dependencies ofproxy-wasm-rust-sdk
and cannot be updated by its Cargo.toml.The current result of
cargo outdated
.That of
cargo outdated --root-deps-only
This PR also includes dependency updates.