Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check only for outdated root dependencies in Cargo checks. #73

Merged

Conversation

nullpo-head
Copy link
Contributor

This PR makes cargo outdated check only direct dependencies only in CI.
Currently, CI also checks the versions of all dependencies in the dependency chain of the crates that proxy-wasm-rust-sdk depends on, and fails if it finds an outdated one. However, they are not direct dependencies of proxy-wasm-rust-sdk and cannot be updated by its Cargo.toml.

The current result of cargo outdated.

Name             Project                        Compat  Latest                         Kind    Platform
----             -------                        ------  ------                         ----    --------
chrono->time     0.1.43                         ---     0.1.44                         Normal  ---
getrandom->wasi  0.10.2+wasi-snapshot-preview1  ---     0.10.0+wasi-snapshot-preview1  Normal  cfg(target_os = "wasi")

That of cargo outdated --root-deps-only

All dependencies are up to date, yay!

This PR also includes dependency updates.

@google-cla
Copy link

google-cla bot commented Feb 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nullpo-head nullpo-head force-pushed the fix/check-outdated-root-deps-only branch from 76b56ea to 2b34605 Compare February 3, 2021 17:55
@google-cla
Copy link

google-cla bot commented Feb 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PiotrSikora
Copy link
Member

Thanks! I have similar change in my local tree, so this looks good, but you need to sign the CLA before I can approve this.

Also, could you please split this into 2 separate PRs (one with --root-deps-only, and another with updates to dependencies)? Those are 2 different changes in my mind.

@nullpo-head nullpo-head force-pushed the fix/check-outdated-root-deps-only branch from 2b34605 to 3a8a5c7 Compare February 5, 2021 08:19
@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Signed-off-by: Takaya Saeki <takaya@tetrate.io>
@nullpo-head nullpo-head force-pushed the fix/check-outdated-root-deps-only branch from 3a8a5c7 to 7622a26 Compare February 5, 2021 11:01
@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@PiotrSikora
Copy link
Member

Thanks for signing the CLA! Could you open the other PR as well? Thanks!

@nullpo-head nullpo-head mentioned this pull request Feb 5, 2021
@nullpo-head
Copy link
Contributor Author

@googlebot I signed it!

@nullpo-head
Copy link
Contributor Author

Thanks so much for your review, Piotr! I've split this PR and opened another one. Although outdated CI is failing for this PR, the other PR to update dependencies will fix it.

@PiotrSikora PiotrSikora changed the title Make cargo-outdated check the root dependencies only Check only for outdated root dependencies in Cargo checks. Feb 5, 2021
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit 57c0051 into proxy-wasm:master Feb 5, 2021
nullpo-head added a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
nullpo-head added a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants