Fix tintColor android issue #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to send all the parameters as android class file try to get tint color and title color prop and if its null then there is no default values set to parse. |
|
Exactly! This is what this PR resolves. In the documentation there are default values available. Default value means that the prop definition is optional. |
|
@mzachariadis for the Effort and PR. I have merged the PR. Thank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing default prop of
titleColorleads to error on Android OS when thetintColoris used.This PR solves the #36 and #29 issues.
Until this PR is merged, a workaround could be the use of both titleColor and tintColor in the object props.