Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMU: Add workaround for broken Tune button #4681

Merged
merged 1 commit into from
May 6, 2024

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented May 4, 2024

If the MMU is processing a command, the Tune button can't be executed and will put the printer into an unrecoverable state.

Mitigate the issue by ignoring the Tune button if the MMU is processing a command. In 99.9% of cases this will only happen when printing. The Tune button is still useful for the particular use case scenario it was added into the firmware in the first place, which is to allow the user to tune the idler stallguard threshold immediately after the printer boots up.

Fixes #4558

For anyone interested, a proper fix may look like this: #4561 but for now it is better to at least mitigate the issue instead of leaving it open in the firmware.

Steps to reproduce a problem:

  1. Send toolchange command to the printer e.g. T0
  2. Hold the Idler in place until you get a "Idler cannot home" error.
  3. Select 'Tune' button
  4. Select 'Done' button (you need to click it 3 times to exit the menu)
  5. Printer is in a 'frozen' state.

Change in memory:
Flash: +16 bytes
SRAM: 0 bytes

If the MMU is processing a command, the Tune button can't be executed.

Change in memory:
Flash: +16 bytes
SRAM: 0 bytes
@gudnimg gudnimg requested review from 3d-gussner and DRracer May 4, 2024 09:18
Copy link

github-actions bot commented May 4, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 16 0 247774 5653 6178 2539
MK3_MULTILANG 16 0 247072 5662 6880 2530

@gudnimg gudnimg added this to the FW 3.14.0 milestone May 4, 2024
@gudnimg
Copy link
Collaborator Author

gudnimg commented May 4, 2024

@3d-gussner adding to 3.14 milestone just so the issue is tied to some milestone, please free to change it if its not appropriate.

Copy link
Collaborator

@DRracer DRracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough as a workaround 👍

@3d-gussner 3d-gussner merged commit eaeb722 into prusa3d:MK3 May 6, 2024
4 checks passed
@3d-gussner
Copy link
Collaborator

@gudnimg We can make a cherry pick to MK3_3.14.0 branch, and let do a short test run for it.

@gudnimg gudnimg deleted the add-workaround-for-tune-button branch September 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MMU Idler cannot home message leads to unrecoverable state
3 participants