Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFW-964: Skip filament unload/load after Shipping factory reset #4689

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

3d-gussner
Copy link
Collaborator

when MMU is enabled. With MMU enabled no filament should be loaded while idle.

when MMU is enabled. With MMU enabled no filament should be
loaded while idle.
@3d-gussner 3d-gussner added this to the FW 3.14.1 milestone May 16, 2024
@3d-gussner 3d-gussner requested review from gudnimg and DRracer May 16, 2024 10:52
Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 10 0 247784 5653 6168 2539
MK3_MULTILANG 10 0 247082 5662 6870 2530

@3d-gussner 3d-gussner requested a review from leptun July 2, 2024 16:54
Copy link
Collaborator

@leptun leptun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with this. Just as a check that I understood the code, this is the unload between xyz cal and thermal model cal?

@3d-gussner
Copy link
Collaborator Author

I don't see any issues with this. Just as a check that I understood the code, this is the unload between xyz cal and thermal model cal?

It just skips the unload/load when MMU is enabled, which is normally a case after someone enabled the MMU and then Shipping reset the printer.
@leptun Thanks for the review and approval.

@3d-gussner 3d-gussner merged commit 152b290 into prusa3d:MK3 Jul 3, 2024
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_PFW-964 branch July 3, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants